Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Jakarta Connectors user guide #445

Merged
merged 13 commits into from
Aug 20, 2020
Merged

Updating Jakarta Connectors user guide #445

merged 13 commits into from
Aug 20, 2020

Conversation

gabrielbussolo
Copy link
Contributor

@gabrielbussolo gabrielbussolo commented Aug 14, 2020

contributing to #427

ps: I'm leaving it as a draft so the task progress can be tracked and errors and suggestions can be reviewed earlier

Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
Copy link
Contributor

@RohitKumarJain RohitKumarJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright year update is required in ../../pom.xml file from 2019 to 2020.

Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo
Copy link
Contributor Author

copyright year update is required in ../../pom.xml file from 2019 to 2020.

Thanks for your review @RohitKumarJain, fixed 🚀

Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
…he project

Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
…owing #447 pull request

Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
Copy link
Contributor

@alwin-joseph alwin-joseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alwin-joseph alwin-joseph merged commit 1c96813 into jakartaee:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants