-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCK Challenge: ee.jakarta.tck.ws.rs.ee.rs.container.responsecontext.JAXRSClientIT#setStatusInfoTest and #setStatusTest #1199
Comments
The TCK challenge should contain the test name that is a subject of the challenge. @jbescos Can you mark the test? (Assumingly it is the referenced one ee.jakarta.tck.ws.rs.ee.rs.container.responsecontext.JAXRSClientIT#setStatusInfoTest) |
Two tests:
|
@jbescos The analysis seems reasonable to me. Is there a PR in the works? |
…AXRSClientIT#setStatusInfoTest and #setStatusTest jakartaee#1199 Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
…AXRSClientIT#setStatusInfoTest and #setStatusTest jakartaee#1199 Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
This seems like a good change to me, but I'm curious about what the actual failure you saw looked like? |
@jim-krueger find here the explication, it was a tricky one: I copy-paste: The test iterates all the HTTP codes sending chunked HTTP requests. When it reaches 304 code, the test mistakenly sends an entity. As it is chunked, the HTTP client thinks the response is done right after the headers. When it tries to make the next request, it already has the response because the entity of 304 was sent. This makes the client to fail because the response is not a correct HTTP response (it only contains the entity). |
Do we close this?. PRs were merged already. |
Change Other keywords will do the same: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
When will we have the new release with this fix? |
The spec says about the 304 Not Modified that:
A 304 response is terminated by the end of the header section; it cannot contain content or trailers
The response code 204 contains also a similar sentence:
A 204 response is terminated by the end of the header section; it cannot contain content or trailers
However
ee.jakarta.tck.ws.rs.ee.rs.container.responsecontext.ResponseFilter#resetStatusEntity
does not reset the entity to null for 304 HTTP code:As a result of this, the response contains the status 304 plus an entity, that I understand is wrong.
I suggest the next change:
This filter is used by
ee.jakarta.tck.ws.rs.ee.rs.container.responsecontext.JAXRSClientIT
testThe text was updated successfully, but these errors were encountered: