Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1162 sse broadcast test #1172

Merged
merged 1 commit into from
Sep 11, 2023
Merged

1162 sse broadcast test #1172

merged 1 commit into from
Sep 11, 2023

Conversation

jim-krueger
Copy link
Contributor

Fixes #1162

@jim-krueger jim-krueger changed the base branch from master to release-4.0 August 21, 2023 20:12
@spericas spericas requested review from spericas and jansupol August 23, 2023 17:53
spericas
spericas approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alwin-joseph alwin-joseph mentioned this pull request Aug 30, 2023
Merged
@jim-krueger
Copy link
Contributor Author

@spericas Do I need to move this PR to master? Thanks

@jim-krueger
Copy link
Contributor Author

@jamezp Since #1162 was your issue I'd like to get your review of this PR. Thanks.
#1173 too please.

jamezp
jamezp approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jim-krueger, I thought I had done that. Looks good to me.

@jim-krueger jim-krueger merged commit 694f39b into jakartaee:release-4.0 Sep 11, 2023
@jim-krueger jim-krueger mentioned this pull request Sep 12, 2023
Merged
@jim-krueger
Copy link
Contributor Author

@spericas @jansupol Is there a reason why the TCK is not built as part of the checks (that would have caught my import ommision)?
2023-08-21T20:12:20.2665381Z [INFO] Reactor Summary for Jakarta RESTful WS Project 4.0.0-SNAPSHOT:
2023-08-21T20:12:20.2665794Z [INFO]
2023-08-21T20:12:20.2669869Z [INFO] Jakarta RESTful WS Project ......................... SUCCESS [ 0.002 s]
2023-08-21T20:12:20.2670582Z [INFO] Jakarta RESTful WS API ............................. SUCCESS [ 28.617 s]
2023-08-21T20:12:20.2671378Z [INFO] Jakarta RESTful WS Examples ........................ SUCCESS [ 2.618 s]
2023-08-21T20:12:20.2672041Z [INFO] Jakarta RESTful WS Specification ................... SUCCESS [ 54.127 s]
2023-08-21T20:12:20.2672516Z [INFO] ------------------------------------------------------------------------
2023-08-21T20:12:20.2672789Z [INFO] BUILD SUCCESS
2023-08-21T20:12:20.2673201Z [INFO] ------------------------------------------------------------------------

@jim-krueger jim-krueger mentioned this pull request Feb 19, 2024
Merged
@jamezp jamezp mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkal chkal chkal approved these changes

@jamezp jamezp jamezp approved these changes

@spericas spericas spericas approved these changes

@jansupol jansupol Awaiting requested review from jansupol

Assignees
No one assigned
Labels
tck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TCK Challenge] Order testing of JAXRSClientIT.sseBroadcastTest results
4 participants
@jim-krueger @chkal @jamezp @spericas