-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in release-4.0 branch #1176
Conversation
examples/src/main/java/jaxrs/examples/bootstrap/BasicJavaSeBootstrapExample.java
Show resolved
Hide resolved
jaxrs-api/src/main/java/jakarta/ws/rs/NotAuthorizedException.java
Outdated
Show resolved
Hide resolved
jaxrs-api/src/test/java/jakarta/ws/rs/core/GenericTypeTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicolas NESMON (@NicoNes) <nicolas.nesmon@gmail.com>
@NicoNes Thanks for looking into this. Generally looks good but let's drop changes that only update import orders, especially static ones. I believe the original 4.0 branch was created too early (before my large PR) and went stale. |
@NicoNes Let's create another issue for the Context/Entity replacement problem you identified. You can assign it to me. |
@spericas Ok I will drop those changes. |
Signed-off-by: Nicolas NESMON (@NicoNes) <nicolas.nesmon@gmail.com>
Sounds like we may need some consensus here. In any case, it probably shouldn't be part of this PR (or any PR not dealing specifically with that). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mkarg Could you review this one too? |
This PR is my proposal to fix multiple regressions introduced by the initial commit (ae1f6ef) on branch "release-4-0" (see issue #1165).
My fix is made of 2 commits:
@spericas in your initial commit, you have massively replace all
Context
byEntity
in javadoc in many classes (I listed them below). I do not revert these changes but I wonder if all of them are really relevant. If not antoher issue and PR will have to be opened to fix it.jakarta.ws.rs.ext.Providers
jakarta.ws.rs.core.UriInfo
jakarta.ws.rs.core.SecurityContext
jakarta.ws.rs.core.Configuration
jakarta.ws.rs.core.HttpHeaders
-- Nicolas