[1183] - rename Entity annotation to Body #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteCat22
force-pushed
the
1183_update_entity_to_body
branch
3 times, most recently
from
3daac4e to
8bb0c2a
Compare
WhiteCat22
force-pushed
the
1183_update_entity_to_body
branch
2 times, most recently
from
1229383 to
4195c75
Compare
spericas
reviewed
Oct 24, 2023
jaxrs-spec/src/main/asciidoc/chapters/asynchronous_processing/_server_api.adoc
Outdated
Show resolved
Hide resolved
WhiteCat22
force-pushed
the
1183_update_entity_to_body
branch
from
4195c75 to
9b536c9
Compare
jim-krueger
approved these changes
Oct 26, 2023
Signed-off-by: Adam Anderson <atanderson9383@gmail.com>
WhiteCat22
force-pushed
the
1183_update_entity_to_body
branch
from
9b536c9 to
27ae97a
Compare
WhiteCat22
commented
Oct 30, 2023
| @@ -55,7 +55,8 @@ parameters. See <<consuming_multipart_formdata>> for more details. | |||
|
|
|||
| The value of a parameter not annotated with `@FormParam` or any of the | |||
| annotations listed in in <<resource_field>>, called the entity | |||
| parameter, is mapped from the request entity body. Conversion between an | |||
| parameter, is mapped from the request entity body. This parameter MUST | |||
| be annotated with the `@Body` annotation. Conversion between an | |||
There was a problem hiding this comment.
@spericas I moved the @Body requirement here.
WhiteCat22
commented
Oct 30, 2023
| forks a (non-request) thread to execute a long running operation and returns | ||
| immediately. Once the execution of the long running operation is complete, | ||
| the connection is resumed and the response returned by calling `resume` on | ||
| the injected instance of `AsyncResponse`. |
There was a problem hiding this comment.
I am leaving these changed (minus the @Body section) since I think I've made it easier to read. I can remove this if you want.
spericas
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1183
Rename the
@Entityannotation to@Bodyand update references.