Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes JaxbLink and related classes and tests #1232

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Removes JaxbLink and related classes and tests #1232

merged 2 commits into from
Mar 25, 2024

Conversation

spericas
Copy link
Contributor

@spericas spericas commented Mar 11, 2024 •
edited
Loading

Removes JaxbLink and related classes and tests. Includes some minor cleanup of versions and version management in pom files too. Issue #1226.

@spericas spericas added the api label Mar 11, 2024
@spericas spericas self-assigned this Mar 11, 2024
@spericas spericas marked this pull request as draft March 11, 2024 17:25
jim-krueger
jim-krueger reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@jim-krueger jim-krueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple copyright changes, sorry.

@spericas
Removes JaxbLink and related classes and tests. Include some minor cl…
ee55fc3 
…eanup of versions and version management in pom files too.
@spericas spericas marked this pull request as ready for review March 12, 2024 13:25
jim-krueger
jim-krueger previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jim-krueger jim-krueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

jamezp
jamezp previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. The only other thing that needs to be done is the signature test file needs to be updated. That said, it looks like the signature test file is not correct as I'm seeing it fail locally for other reasons. We could just update it in a follow up PR.

jim-krueger
jim-krueger reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@jim-krueger jim-krueger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the copyright confusion. Shame on me for assuming that copyright practices would be universal. https://www.eclipse.org/projects/handbook/#legaldoc-faq

@spericas
Updates copyright headers.
b20df65 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas dismissed stale reviews from jamezp and jim-krueger via b20df65 March 14, 2024 16:57
@spericas spericas merged commit b5a39db into jakartaee:main Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarg mkarg mkarg left review comments

@jim-krueger jim-krueger jim-krueger approved these changes

@jansupol jansupol jansupol approved these changes

@jamezp jamezp jamezp approved these changes

Assignees

@spericas spericas

Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spericas @jamezp @mkarg @jansupol @jim-krueger