-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UriInfo#getMatchedResourceTemplate method #1236
Conversation
Signed-off-by: jansupol <jan.supol@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be TCK additions to ee.jakarta.tck.ws.rs.ee.rs.core.uriinfo.URIInfoTest?
Definitely. I plan to add those if accepted |
Would be nice to get this into 4.0. Not sure if there is enough runway. |
Added TCK tests Signed-off-by: jansupol <jan.supol@oracle.com>
Added the TCK tests |
jaxrs-tck/src/main/java/ee/jakarta/tck/ws/rs/jaxrs40/ee/rs/core/uriinfo/JAXRSClientIT.java
Outdated
Show resolved
Hide resolved
jaxrs-tck/src/main/java/ee/jakarta/tck/ws/rs/jaxrs40/ee/rs/core/uriinfo/JAXRSClientIT.java
Outdated
Show resolved
Hide resolved
With the TCK I am in favor of adding this to the Jakarta Rest 4.0 content. Can we get a quick vote on this? @ivargrimstad Can we still add this relatively minor, but nice to have, improvement to 4.0 (assuming it passes a vote)? |
Signed-off-by: jansupol <jan.supol@oracle.com>
An alternative with returning the List of templates #1245 |
...s-tck/src/main/java/ee/jakarta/tck/ws/rs/jaxrs40/ee/rs/core/uriinfo/UriInfoTestResource.java
Show resolved
Hide resolved
Signed-off-by: jansupol <jan.supol@oracle.com>
I slightly prefer the #1245 over this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In talking with some of the OTel folks, they seemed to prefer the string return type so they don't have to combine the list to a string.
Yes, this was run past Andrew, the originator of the issue and he concurred. So this is the PR that should be merged. |
Implements #1191
There can be a discussion of the actual method name, as the proposed name was
getResourceTemplate
, butgetMatchedResourceTemplate
is more aligned with othermatched
methods.Also, the return type can be in the form of a list, but the discussion was to return a string