-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta Activation 2.0 apidocs #173
Conversation
Deploy preview for jakartaee-specifications ready! Built with commit 96744ef https://deploy-preview-173--jakartaee-specifications.netlify.app |
When I look at the rendered javadoc, I don't see a version displayed anywhere. There's no indication if this is 2.0, or 1.2, or 2.0-SNAPSHOT... We need something to indicate what version of Activation we are looking at. Thanks. |
Although I started this review before Milestone 1, I'm going to hand this off to @starksm64 as the official "mentor" for getting Jakarta Activation through the final review process. I've assigned this Issue to Scott for further reviewing. Questions? Don't hesitate to ask. Thanks! |
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
I deleted the Spec Checklist comment in this PR since that is not required in the Apidocs PR, only the Spec PR. I also updated the top-level Description checklist to indicate that this is only for the Apidocs. |
the only change this PR contains is removal of offending MANIFEST.MF file from apidocs directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There does need to be an update of the api docs as the current version refers to 2.0.0-RC3. The javadocs also do not have a reference to the EFSL license terms in the footer. See the injection-api javadoc plugin setup as an example:
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
javadoc should be fixed |
@starksm64 the spec PR (#172) has been merged/closed already, so should be this. Thx! |
Closing. Oops, meant to merge first... :-) |
Add minutes for March 31 Platform call
Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com
Specification PR template
When creating a specification project release review, create two PRs with the content divided as follows.
Include the following in PR#2: