Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jakarta Activation 2.0 apidocs #173

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Jakarta Activation 2.0 apidocs #173

merged 2 commits into from
Oct 21, 2020

Conversation

lukasj
Copy link
Contributor

@lukasj lukasj commented Jun 2, 2020 •
edited by kwsutter
Loading

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

Specification PR template

When creating a specification project release review, create two PRs with the content divided as follows.

Include the following in PR#2:

  • Specification JavaDoc in the wombat/x.y/apidocs directory.

@lukasj lukasj mentioned this pull request Jun 2, 2020
Closed
10 tasks
@netlify
Copy link

netlify bot commented Jun 2, 2020 •
edited
Loading

Deploy preview for jakartaee-specifications ready!

Built with commit 96744ef

https://deploy-preview-173--jakartaee-specifications.netlify.app

@kwsutter kwsutter added the wave:1 Used for release tracking purposes label Jun 2, 2020
@kwsutter kwsutter added this to the Jakarta EE 9 Milestone 1 milestone Jun 2, 2020
@kwsutter kwsutter added the draft Work in Progress label Jun 2, 2020
@kwsutter
Copy link
Contributor

kwsutter commented Jun 2, 2020

When I look at the rendered javadoc, I don't see a version displayed anywhere. There's no indication if this is 2.0, or 1.2, or 2.0-SNAPSHOT... We need something to indicate what version of Activation we are looking at. Thanks.

@kwsutter kwsutter mentioned this pull request Jun 10, 2020
Merged
10 tasks
@kwsutter kwsutter requested a review from starksm64 July 13, 2020 19:53
@kwsutter
Copy link
Contributor

Although I started this review before Milestone 1, I'm going to hand this off to @starksm64 as the official "mentor" for getting Jakarta Activation through the final review process. I've assigned this Issue to Scott for further reviewing. Questions? Don't hesitate to ask. Thanks!

@lukasj
remove meta-inf folder
e42039f 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@jakartaee jakartaee deleted a comment from starksm64 Jul 24, 2020
@kwsutter
Copy link
Contributor

kwsutter commented Jul 24, 2020 •
edited
Loading

I deleted the Spec Checklist comment in this PR since that is not required in the Apidocs PR, only the Spec PR. I also updated the top-level Description checklist to indicate that this is only for the Apidocs.

@lukasj
Copy link
Contributor Author

lukasj commented Jul 28, 2020

the only change this PR contains is removal of offending MANIFEST.MF file from apidocs directory

starksm64
starksm64 suggested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@starksm64 starksm64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There does need to be an update of the api docs as the current version refers to 2.0.0-RC3. The javadocs also do not have a reference to the EFSL license terms in the footer. See the injection-api javadoc plugin setup as an example:

https://github.com/eclipse-ee4j/injection-api/blob/5c9e19e192e34095f23d3aa317ca1fdf76110b09/pom.xml#L117

@lukasj
update javadoc to match release version, add missing spec license
96744ef 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj requested a review from starksm64 August 4, 2020 15:08
@lukasj
Copy link
Contributor Author

lukasj commented Aug 4, 2020

javadoc should be fixed

@kwsutter kwsutter added ballot Delivered to the Specification Committee for ballot final Ready for Vote and removed draft Work in Progress labels Sep 10, 2020
@lukasj
Copy link
Contributor Author

lukasj commented Oct 14, 2020

@starksm64 the spec PR (#172) has been merged/closed already, so should be this. Thx!

@kwsutter
Copy link
Contributor

kwsutter commented Oct 21, 2020 •
edited
Loading

Closing. Oops, meant to merge first... :-)

@kwsutter kwsutter closed this Oct 21, 2020
@kwsutter kwsutter reopened this Oct 21, 2020
@kwsutter kwsutter merged commit c6726d1 into jakartaee:master Oct 21, 2020
@lukasj lukasj deleted the jaf_api branch October 21, 2020 16:24
starksm64 pushed a commit to starksm64/specifications that referenced this pull request Dec 20, 2021
@ivargrimstad
Merge pull request jakartaee#173 from ivargrimstad/minutes-march-31
c13c758 
Add minutes for March 31 Platform call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starksm64 starksm64 starksm64 approved these changes

@kwsutter kwsutter kwsutter approved these changes

Assignees
No one assigned
Labels
ballot Delivered to the Specification Committee for ballot final Ready for Vote wave:1 Used for release tracking purposes
Projects
None yet
Milestone
Jakarta EE 9
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasj @kwsutter @starksm64