Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add older TLDs to enable JSTL 1.2/2.0 URI backward compatibility #202

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Add older TLDs to enable JSTL 1.2/2.0 URI backward compatibility #202

merged 2 commits into from
Mar 3, 2022

Conversation

volosied
Copy link
Contributor

@volosied volosied commented Jan 19, 2022 •
edited
Loading

fixes #201

  • Added the older TLDs under a new name ( <tag>-<version>.tld) This format is similar to other tlds.
  • Duplicated the permittedTaglibs.tld file -- one for sun URIs and one for jakarta URIs

@volosied volosied self-assigned this Jan 19, 2022
@volosied volosied marked this pull request as draft January 19, 2022 17:14
@volosied volosied force-pushed the uri-backwardd-compatibility branch 2 times, most recently from 87774b3 to d0d5428 Compare February 23, 2022 19:27
@volosied volosied marked this pull request as ready for review February 23, 2022 20:06
pnicolucci
pnicolucci reviewed Feb 23, 2022
View reviewed changes
Copy link
Contributor

@pnicolucci pnicolucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about the permitted description. I just want to preserve the language around el taglibs.

@volosied volosied mentioned this pull request Feb 23, 2022
Closed
@volosied volosied force-pushed the uri-backwardd-compatibility branch 2 times, most recently from b09243b to dcf9728 Compare March 2, 2022 20:39
@volosied
Split permittedTagLibs into two files for sun and jakarta uris
d53996c 
Update namespace for permittedTaglibs

Add back permittedTaglibs descriptions

Review comments

Remove copyright

Revert to orignal permittedtaglibs
@volosied volosied force-pushed the uri-backwardd-compatibility branch from dcf9728 to d53996c Compare March 3, 2022 03:18
@volosied
Copy link
Contributor Author

volosied commented Mar 3, 2022

Squashed some commits. Merging now.

@volosied volosied merged commit e7c1d31 into jakartaee:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnicolucci pnicolucci pnicolucci approved these changes

Assignees

@volosied volosied

Labels
JakartaEE10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backward Compatibility for Older http://java.sun.com/jsp/jstl/* URIs
2 participants
@volosied @pnicolucci