Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composite project setup #2

Merged
merged 1 commit into from
May 29, 2019
Merged

Fix composite project setup #2

merged 1 commit into from
May 29, 2019

Conversation

MattiasBuelens
Copy link
Contributor

@MattiasBuelens MattiasBuelens commented May 29, 2019

Another attempt! 😛

That seems to fix all build-related errors. There are still type errors because of microsoft/TypeScript#14877, but you could work around that with something like self as DedicatedWorkerGlobalScope.

@jakearchibald jakearchibald merged commit ec1fbce into jakearchibald:master May 29, 2019
@jakearchibald
Copy link
Owner

@MattiasBuelens thank you! I think this is pretty much as good as it gets.

@jakearchibald
Copy link
Owner

I'll write this up at SO tomorrow and credit you.

@MattiasBuelens MattiasBuelens deleted the fix-composite-setup branch May 29, 2019 18:23
@MattiasBuelens
Copy link
Contributor Author

Sweet! I'm Mattias Buelens on SO, in case you want to @ me. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants