Skip to content

Commit

Permalink
Remove instrumenter
Browse files Browse the repository at this point in the history
This infrastructure is used to create new RWC tests by making an
"instrumented" tsc executable that outputs IO information.

Per internal discussion, we don't think we need this sort of thing
anymore, so remove it rather than try to make it work.

If we wanted to make it work, I'd add a new entrypoint to the tsc
project which calls the logged IO code directly, which matches what the
old source-level modification script tacked onto the real tsc.
  • Loading branch information
jakebailey committed Oct 3, 2022
1 parent b0cf9f5 commit 6d3661d
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 101 deletions.
17 changes: 0 additions & 17 deletions Gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -567,23 +567,6 @@ task("baseline-accept").description = "Makes the most recent test results the ne
task("baseline-accept-rwc", () => baselineAccept(localRwcBaseline, refRwcBaseline));
task("baseline-accept-rwc").description = "Makes the most recent rwc test results the new baseline, overwriting the old baseline";

// TODO(jakebailey): figure out what tsc-instrumented and such are for and what do to with them.

const buildLoggedIO = () => buildProject("src/loggedIO/tsconfig-tsc-instrumented.json");
const cleanLoggedIO = () => del("built/local/loggedIO.js");
cleanTasks.push(cleanLoggedIO);

const buildInstrumenter = () => buildProject("src/instrumenter");
const cleanInstrumenter = () => cleanProject("src/instrumenter");
cleanTasks.push(cleanInstrumenter);

const tscInstrumented = () => exec(process.execPath, ["built/local/instrumenter.js", "record", cmdLineOptions.tests || "iocapture", "built/local/tsc.js"]);
task("tsc-instrumented", series(lkgPreBuild, parallel(localize, buildTsc, buildServer, buildServices, buildLssl, buildLoggedIO, buildInstrumenter), tscInstrumented));
task("tsc-instrumented").description = "Builds an instrumented tsc.js";
task("tsc-instrumented").flags = {
"-t --tests=<testname>": "The test to run."
};

// TODO(rbuckton): Determine if we still need this task. Depending on a relative
// path here seems like a bad idea.
const updateSublime = () => src(["built/local/tsserver.js", "built/local/tsserver.js.map"])
Expand Down
43 changes: 0 additions & 43 deletions src/instrumenter/instrumenter.ts

This file was deleted.

15 changes: 0 additions & 15 deletions src/instrumenter/tsconfig.json

This file was deleted.

26 changes: 0 additions & 26 deletions src/loggedIO/tsconfig-tsc-instrumented.json

This file was deleted.

0 comments on commit 6d3661d

Please sign in to comment.