Fix theme dropdown tooltip and refactor to Radix DropdownMenu #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 11. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…t imports Fix the "press t" tooltip showing behind the theme dropdown by passing dropdown open state to ShortcutTooltip's new disabled prop. Also replace all `import * as React from "react"` with direct named imports across the codebase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Also fix tooltip disabled behavior to keep Tooltip mounted (using
open={false}) instead of unmounting it, which was causing the dropdown
to reset its state.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace custom dropdown implementation with Radix DropdownMenu, which natively handles click-outside, escape key, focus management, and keyboard navigation. ThemeToggle now owns its tooltip internally via a shortcut prop, eliminating state lifting through TopNav. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bump dropdown z-index above nav, use subtle muted hover instead of saturated accent, align dropdown to start (left) of trigger, and disable modal overlay for proper pointer events. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jakebodea
force-pushed
the
fix/theme-dropdown-tooltip
branch
from
2e5501d to
73978bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
t" tooltip is suppressed when dropdown is open, handled internally by ThemeToggle via ashortcutprop instead of state lifting through TopNavimport * as Reactwith direct named imports across the codebase (15 files)Test plan
t" tooltip; opening dropdown hides ittquick-toggles between light/dark🤖 Generated with Claude Code