Sticky page title on desktop + theme dropdown fixes#14
Merged
Conversation
The mobile sticky title (scrolls with page, catches in the nav bar) now works on all screen sizes. Removed the dual mobile/desktop rendering split in PageTitle — one sticky element for all viewports. Made the nav background transparent on desktop so the title bar shows through when caught. Also fixed the nav indicator not following the active tab by adding pathname to the useLayoutEffect dependency array. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Move sticky positioning from PageTitle into PageWrapper so PageTitle stays a pure typography component and home page is unaffected. Make TopNav transparent on desktop so the page title slides into the nav row. Fix theme dropdown not opening on mobile by guarding hover handlers with pointerType check, and align dropdown to end on mobile. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jakebodea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PageTitleintoPageWrappersoPageTitlestays a pure typography component and the home page hero is unaffectedpointerleavewas racing the open)Test plan
🤖 Generated with Claude Code