fix: correct page transition direction and centralize nav config#25
Merged
fix: correct page transition direction and centralize nav config#25
Conversation
- Fix projects/timeline transition sliding from wrong side (nav order mismatch) - Extract nav items to shared lib/nav-config.ts for single source of truth - TopNav and NavigationProvider now both import from nav-config Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ibility Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/nav-config.tsfor single source of truthMade with Cursor
Note
Low Risk
Small refactor to shared constants plus a minor behavior fix in transition direction logic; limited to navigation config usage.
Overview
Centralizes the app’s navigation configuration into a new
lib/nav-config.ts, exportingnavItemsplus a derivednavOrderas a single source of truth.Updates
TopNavandNavigationProviderto import from this shared config, aligning tab rendering/shortcuts with the transition-direction calculation so cross-section animations no longer slide from the wrong side.Written by Cursor Bugbot for commit baa9d3f. This will update automatically on new commits. Configure here.