Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extraneous 'dhcpServer' line that broke the build. #25

Merged
merged 6 commits into from
Jul 27, 2024
Merged

Removed extraneous 'dhcpServer' line that broke the build. #25

merged 6 commits into from
Jul 27, 2024

Conversation

SamErde
Copy link
Contributor

@SamErde SamErde commented Jul 24, 2024

That little guy on the first line broke the module build when I was testing locally. This PR removes the extraneous 'dHCPServer' line. Sorry for not bothering with an issue! 😆

    dHCPServer
    foreach ($dhcpServer in $DHCPServers) {
        $NameProtectionv4Configuration = (Get-DhcpServerv4DnsSetting -ComputerName $dhcpServer.IPAddress).NameProtection
        $NameProtectionv6Configuration = (Get-DhcpServerv6DnsSetting -ComputerName $dhcpServer.IPAddress).NameProtection
        if ($NameProtectionConfigurationList.'Server IP' -notcontains $dhcpServer.IPAddress) {
            $AddToList = [PSCustomObject]@{
                'Server Name'          = $dhcpServer.DnsName
                'Server IP'            = $dhcpServer.IPAddress
                'IPv4 Name Protection' = $NameProtectionv4Configuration
                'IPv6 Name Protection' = $NameProtectionv6Configuration
            }
        }

        $NameProtectionConfigurationList += $AddToList
    }

@SamErde SamErde changed the base branch from main to testing July 24, 2024 22:06
@jakehildreth jakehildreth merged commit 508c5bd into jakehildreth:testing Jul 27, 2024
@SamErde SamErde deleted the se-fix-GetBTNameProtectionConfiguration branch July 27, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants