Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/parsing cases #17

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Feature/parsing cases #17

wants to merge 15 commits into from

Conversation

creisle
Copy link
Collaborator

@creisle creisle commented Mar 9, 2023

No description provided.

creisle added 3 commits March 8, 2023 14:11
@creisle
Add parsing updates
8c5991c 
Deals with several edge-cases to create a more human-readable output
that matches the input more as expected by the reader

resolves: #16
@creisle
Add unidecode dependency
c734a33
@creisle
Add multi-level table header handling
5350c7d 
resolves: #14
@creisle creisle added the enhancement New feature or request label Mar 9, 2023
@creisle creisle requested a review from jakelever March 9, 2023 18:25
@creisle creisle self-assigned this Mar 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023 •
edited
Loading

Codecov Report

Patch coverage: 94.24% and project coverage change: +2.16 🎉

Comparison is base (19cce75) 86.39% compared to head (579e681) 88.56%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   86.39%   88.56%   +2.16%     
==========================================
  Files           5        6       +1     
  Lines         669      787     +118     
==========================================
+ Hits          578      697     +119     
+ Misses         91       90       -1
Flag Coverage Δ
unittests 88.56% <94.24%> (+2.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/bioconverters/utils.py 94.02% <94.20%> (+4.47%) ⬆️
src/bioconverters/constants.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@creisle creisle marked this pull request as draft March 15, 2023 17:58
@creisle
Copy link
Collaborator Author

creisle commented Mar 15, 2023

@jakelever I am converting this to a draft pending approval for the other parser updates in #16

creisle added 7 commits March 15, 2023 11:46
@creisle
Set tail to empty string if not set
579e681
@creisle
Keep label of AbstractText elements as text
8f3ad28 
resolves: #19
@creisle
Improve sectioning
8515130 
- add new types of section labels to keep
- add option to get section path
@creisle
improve table parsing
929423c 
- parse non-std table formats by attempting to normalize table
  structures where possible
- add tests for table parsing
@creisle
Add type annotations
f092a3a
@creisle
Merge branch 'master' into feature/parsing-cases
0b8f5c6
@creisle
Clean up test cases: #20
d0d50fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelever jakelever Awaiting requested review from jakelever

Assignees

@creisle creisle

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@creisle @codecov-commenter