Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create page functionality #44

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Add create page functionality #44

merged 3 commits into from
Jan 2, 2023

Conversation

ahmetrehaseker
Copy link
Contributor

Notion API expects rich_text instead of text while querying the database with property filtering

jakeswenson
jakeswenson requested changes Nov 13, 2022
View reviewed changes
Copy link
Owner

@jakeswenson jakeswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I appreciate it. I think the build is failing due to a cargo fmt issue, do you know if you're seeing that on your end?

I left a comment to add a doc comment for the private method we'd be making public in this PR.

Thanks again!

src/lib.rs Outdated Show resolved Hide resolved
jakeswenson
jakeswenson approved these changes Nov 19, 2022
View reviewed changes
Copy link
Owner

@jakeswenson jakeswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you for all the improvements! If you don't want to add the doc comment I can before releasing? Let me know how you'd like to proceed!

src/lib.rs Show resolved Hide resolved
@ahmetrehaseker
Copy link
Contributor Author

Sorry, I should add WIP tag I guess, I am testing this now when I finalize the tests I will add the documentation

@jakeswenson jakeswenson added the WIP Work In Progress label Nov 19, 2022
@ahmetrehaseker ahmetrehaseker changed the title Change text to rich_text Add create page functionality Nov 19, 2022
@ahmetrehaseker
Copy link
Contributor Author

I am unable to remove that WIP tag, I tested the changes the PR is ready to be merged I guess.

@auscyber
Copy link
Contributor

auscyber commented Jan 1, 2023

Can you yknow merge this?

@jakeswenson jakeswenson removed the WIP Work In Progress label Jan 2, 2023
jakeswenson
jakeswenson approved these changes Jan 2, 2023
View reviewed changes
Copy link
Owner

@jakeswenson jakeswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jakeswenson jakeswenson enabled auto-merge (squash) January 2, 2023 07:55
@jakeswenson jakeswenson merged commit 43fd57a into jakeswenson:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakeswenson jakeswenson jakeswenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmetrehaseker @auscyber @jakeswenson