-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make baseof.html
more modular
#46
Comments
Yes I think this is a good solution for use cases I haven't thought about. Makes the theme more extensible. |
Okay I'll work on this then. |
While looking at @jakewies if you like this idea too I can implement this along side this PR as they are both related to refactoring |
Definitely! |
I'm running into the same issue / want today, albeit a slightly different use case — I want a simple emoji to be my favicon @kentnek are you still working on this? if not, I can PR in the addition for |
@wilsonehusin oh please feel free to tackle it. I'm currently busy with real life so I can't work on this at the moment. Thank you! |
Thanks @wilsonehusin I will make sure to take a peak. I have a lot of stuff to tackle for this project, been very busy IRL. |
no problem @jakewies -- it's a one-liner change so perhaps it can be some entertainment on a tough day :D anyhow, thanks for the wonderful work! truly appreciate that you open source the product :) |
Thank you @wilsonehusin for #131 ! Would you be interested and also working on a few other partials? If you haven't come across the need in your own work, then not to worry. Just curious. I seee that #46 aims to address a few other parts of the base template like |
I'll stop by again when I come across some other use cases, I don't have anything in mind at the moment though 🙂 |
No worries! I will keep this Issue open for future newcomers who might want to make some contributions. |
I think we can make the
baseof.html
more modular by splitting into several partials that powerusers like me might modify, e.g.meta.html
,favicon.html
,styles.html
, etc. you get the idea. Some examples are:partials/base/title.html
This partial would hold the
<title>
element, for people to customize the website's title.partials/base/favicon.html
Nowadays including a single
favicon.ico
is probably not enough for all devices. The best practice would be use a favicon generator to generate multiple sizes and a webmanifest file, so the icon would look crisp in all scenarios.I personally use realfavicongenerator to help me prepare the icon package, and I'd put this chunk in
baseof.html
to configure:If we have the partial
favicon.html
, I can just replace the existing linewith that chunk without needing to clone the
baseof.html
file.The text was updated successfully, but these errors were encountered: