Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets: scss: Use softer tones for hyperlinks and highlighting. #160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lzlrd
Copy link

@lzlrd lzlrd commented Feb 18, 2021

No description provided.

Signed-off-by: Diab Neiroukh <lazerl0rd@thezest.dev>
This allows marking to look good on both light and dark themes.
@gprst
Copy link
Contributor

gprst commented Feb 28, 2021

I wonder if this is not the kind of SCSS to put in the assets/scss/custom.scss file 🤔 I believe the theme as is is a good starting point to let people style paragraphes, links, and headers to their liking.

@lzlrd
Copy link
Author

lzlrd commented Mar 1, 2021

I wonder if this is not the kind of SCSS to put in the assets/scss/custom.scss file 🤔 I believe the theme as is is a good starting point to let people style paragraphs, links, and headers to their liking.

I understand your concerns, however I think that - by default - the theme should have a unified look for the large chunk of users that won't end up playing with it.

In this case, the colours of hyperlinks and marking looked very "off" as they were defaulting to whatever the browser would set and, on Chrome, ended up with a very sharp blue that didn't match the soft greys and blacks that this the uses.

@lzlrd
Copy link
Author

lzlrd commented Apr 9, 2024

Note: Further adjustment needed if used in conjunction with #159. See lzlrd@ef7659f and lzlrd@8107afc, for an example.

lzlrd pushed a commit to lzlrd/hugo-theme-codex that referenced this pull request Apr 10, 2024
Modified to support jakewies#159
and jakewies#160.

Co-authored-by: Diab Neiroukh <work@thezest.dev>
lzlrd pushed a commit to lzlrd/hugo-theme-codex that referenced this pull request Apr 10, 2024
Modified to support jakewies#159
and jakewies#160.

Co-authored-by: Diab Neiroukh <work@thezest.dev>
lzlrd pushed a commit to lzlrd/hugo-theme-codex that referenced this pull request Apr 10, 2024
Modified to support jakewies#159
and jakewies#160.

Co-authored-by: Diab Neiroukh <work@thezest.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants