Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating new sections #19

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

kentnek
Copy link
Collaborator

@kentnek kentnek commented Jun 18, 2020

Hi! I really like this theme and in the process of integerating it into my website, I'd like to contribute a few changes, which will likely come in several PRs.

This first PR makes it easier to add a new section and its corresponding menu, which is what I did for my site.

Please feel free to comment on the changes. Thanks!

@jakewies
Copy link
Owner

Hey @kentnek ! I'm glad you're enjoying it. This change looks great! I want to test it out locally in a bit before merging, but looks great to me.

@jakewies
Copy link
Owner

Everything looks good! Ready to merge, just want to get some insight into your change at nav.html partial so I can understand what's happening now.

@kentnek
Copy link
Collaborator Author

kentnek commented Jun 19, 2020

Hi Jake, sorry I went to bed after raising the PR 😂 I've explained the gotemplate line above.

@jakewies jakewies merged commit 28ccdc0 into jakewies:master Jun 19, 2020
@jakewies
Copy link
Owner

Thanks for your contribution @kentnek !

@jakewies
Copy link
Owner

@all-contributors please add @kentnek for code

@allcontributors
Copy link
Contributor

@jakewies

I've put up a pull request to add @kentnek! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants