Add support for Disqus and Google Analytics #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakewies
reviewed
Jun 24, 2020
| @@ -13,7 +11,6 @@ | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <meta http-equiv="content-type" content="text/html; charset=utf-8"> | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
| <meta name="google-site-verification" content="8cyiY374WL2LGr87fBghcdJCRx6BaPNBvLjeZlk6tyc" /> | |||
There was a problem hiding this comment.
Whoops. I think I left this in on accident from when I ported my old site to a theme. That's not good 😵
jakewies
reviewed
Jun 24, 2020
| @@ -3,28 +3,34 @@ | |||
| {{ end }} | |||
|
|
|||
| {{ define "main" }} | |||
| {{ $dateFormat := .Site.Params.dateFormat | default "Jan 2 2006" }} | |||
| {{ $dateFormat := .Site.Params.dateFormat | default "Jan 2 2006" }} | |||
There was a problem hiding this comment.
Formatting has been an issue in this project I've noticed. Probably a lack of symmetry in formatting tools. Maybe we can consider something like prettier in the future.
|
How is disqus added from the config file? I still can't seem to get it to show up in posts. Site renders fine. I've got |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can easily integrate Disqus and Google Analytics by utilizing Hugo's existing internal templates. Users can opt in by specifying configs.
Also I reformatted
layouts/_default/single.htmlsince it was a little bit messy.