Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how prismjs is loaded. #50

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Change how prismjs is loaded. #50

merged 1 commit into from
Jun 24, 2020

Conversation

jlebar
Copy link
Contributor

@jlebar jlebar commented Jun 24, 2020

  • Load minified code (3kB vs 30kB)
  • Add prism autoloader so that we get highlighting for languages we
    use.
  • Hardcode exact prism version. Perhaps this is controversial, but it
    saves a redirect for each request, shaving off 30ms on a fast
    connection.

 - Load minified code (3kB vs 30kB)
 - Add prism autoloader so that we get highlighting for languages we
   use.
 - Hardcode exact prism version.  Perhaps this is controversial, but it
   saves a redirect for each request, shaving off 30ms on a fast
   connection.
@kentnek
Copy link
Collaborator

kentnek commented Jun 24, 2020

Load minified code (3kB vs 30kB)

Aw yiss.

Add prism autoloader so that we get highlighting for languages we use.

Oh this is pretty cool, thanks for pointing this out.

Hardcode exact prism version.

We're already using 1.2 instead of 1.x.x, so changing to the exact version makes sense here too.

I'm good with this @jakewies :D

@jakewies
Copy link
Owner

Great additions! I didn't realize there was an autoloader 🤯

@jakewies
Copy link
Owner

@kentnek do you have merge perms? I think you should. If you do go ahead and merge this in and you can add @jlebar as a contributor using the @all-contributor command! If you don't have merge perms let me know and I'll figure out what to do to get you them. 😄

@jakewies
Copy link
Owner

Awesome stuff @jlebar thank you for contributing!

@kentnek
Copy link
Collaborator

kentnek commented Jun 24, 2020

@jakewies Oh cool let me do that!

@kentnek kentnek merged commit d713ed3 into jakewies:master Jun 24, 2020
@kentnek
Copy link
Collaborator

kentnek commented Jun 24, 2020

@all-contributors please add @jlebar for code.

@allcontributors
Copy link
Contributor

@kentnek

I've put up a pull request to add @jlebar! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants