Add prettier #57
Merged
Add prettier #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prettier has been added as a dev dependency along with a few other tools that run prettier on staged files before committing them. This prevents any file from being committed that hasn't gone through the project's formatting. Check the prettier.config.js file for details on how we format files.
kentnek
reviewed
Jun 27, 2020
kentnek
reviewed
Jun 27, 2020
kentnek
reviewed
Jun 27, 2020
|
Changes made 👍 |
kentnek
reviewed
Jun 28, 2020
|
@jakewies can you revert the md/js files and reapply the updated prettyconfig on all of them? Other than that great work! |
|
Ya just realized there are a few MD files at the root that I hadn’t reverted. I’ll clean this up. |
|
@kentnek applied the changes to the md/js files. Let me know if I missed something. If it looks good you can merge 😄 |
|
oh sorry I've been occupied with work recently. the PR looks good to me now! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #54.
This PR adds formatting to the project using
prettier. I have runprettieron the entire project to get the initial formatting in place. From this point forward, any file being committed must first pass through prettier for formatting.prettier.config.jsfile for formatting rules.prettierignorefile to see what's not being formatted