-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#73 Enable summary for the post in blog #75
base: master
Are you sure you want to change the base?
Conversation
- enabling summary params variable
Closes #73 |
Thank you for your contribution!
Could you limit the scope of this PR to only adding the summary? Also a screenshot of the summary in the list would be great. Regarding your bottom bar, could you separate it to a different PR, and elaborate on the use case? |
@aldrineeinsteen thanks for this work! I agree with @kentnek, let's try and keep this one to the addition of an optional summary in the post list only. Also, I notice git picking up some changes related to formatting. This shouldn't be the case because we have |
Could you replace the screenshot in the PR to that of the "summary"? |
- updating the configuration from params.blog to params - documentation has been added to enable configuration of summary for blogs Closes jakewies#73
I think the code looks good now, but the styling needs some magic from @jakewies. In my opinion, the summary text and "Read more" should be slightly lighter than the main title. Also I'd prefer the "Read more" button to be left-aligned so it doesn't break the vertical flow of the page. |
@kentnek as far as formatting goes, I made a mention of this in an early review. The comment is still unresolved. I'm waiting to here back from @aldrineeinsteen on the topic. I'll take a look at the styles later today and work my magic. |
done :) |
Finally got around to making style adjustments on this PR. A few notes here:
@kentnek let me know your thoughts on the visuals. If things are good to go I'll handle the conflicts and we can merge this one. |
I think it's a good idea to add the |
I thought the same. I didn't know if it was frowned upon to update the default example content provided by Hugo. But I'll go ahead and clean those up. |
The changes add a clean navigation bar in the bottom of the blog.
The active element will be bold and highlighted