Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rework branch dependencies #104

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

barsoosayque
Copy link
Contributor

bevy_dock just released a new version with egui = "0.20.0" and inspector became incompatible with it 😞. This PR is simple cargo upgrade on the rework branch.

@jakobhellermann
Copy link
Owner

I don't think this will work because bevy_egui has not updated yet

@barsoosayque
Copy link
Contributor Author

Ah, you are correct. I built the wrong thing 😩

@jakobhellermann
Copy link
Owner

The egui_dock crate is pinned to a specific commit so I wouldnt expect upstream updates to break anything:

egui_dock = { git = "https://github.com/Adanos020/egui_dock", rev = "041e5f362c281c286a63edeef2f7d02dbd5d62f4" }

@barsoosayque
Copy link
Contributor Author

Added a little import fix; and as a note, bevy_egui!139 does fix the type mismatch, everything works

@barsoosayque
Copy link
Contributor Author

barsoosayque commented Dec 12, 2022

Updated bevy_egui, build succeeded

@jakobhellermann jakobhellermann merged commit 1460beb into jakobhellermann:rework Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants