Update to bevy 0.11 #141
Update to bevy 0.11 #141
Conversation
crates/bevy-inspector-egui/examples/quick/filter_query_inspector.rs
Outdated
Show resolved
Hide resolved
| @@ -366,13 +366,6 @@ impl InspectorUi<'_, '_> { | |||
| } | |||
| TypeInfo::Enum(info) => self.ui_for_enum_many(info, ui, id, options, values, projector), | |||
| TypeInfo::Value(info) => self.ui_for_value_many(info, ui, id, options), | |||
| TypeInfo::Dynamic(_) => { | |||
There was a problem hiding this comment.
As I understand it, this should technically be replaced with an is_dynamic check, but I could not figure out whether this is actually relevant anymore.
There was a problem hiding this comment.
I am unsure. (inherited from #137 )
There was a problem hiding this comment.
I'm not too familiar with Reflect specifics, thanks for pointing that out
| @@ -894,7 +887,10 @@ impl InspectorUi<'_, '_> { | |||
| id: egui::Id, | |||
| options: &dyn Any, | |||
| ) -> bool { | |||
| let type_info = value.get_type_info(); | |||
| let Some(type_info) = value.get_represented_type_info() else { | |||
There was a problem hiding this comment.
I panicked with a message similar to the unreachable call below, as this can only happen when you create a dynamic enum that does not represent any type, which AIUI should not be able to happen with a well-formed reflect impl.
There was a problem hiding this comment.
I changed get_type_info to get_represented_type_info because I thought get_type_info was removed as I had a compile error leading me that way, but I might have been mistaken as I see it in there: https://docs.rs/bevy/0.11.0/bevy/reflect/struct.TypeRegistryInternal.html#method.get_type_info ; maybe I was just missing a trait/derive or import ?
There was a problem hiding this comment.
@Vrixyz nope that part's correct, I just highlighted the wrong line... I'm referring to the error handling below
This required further upgrades to other related dependencies: - bevy_egui 0.20 > 0.21 - egui 0.21 > 0.22 - egui_dock 0.4 > 0.6 - egui-gizmo 0.10 > 0.11
|
Thanks for the PR! |
Updates on top of #137
bevy 0.11crate