Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can node_index and child_index be replaced with css selector syntax? #297

Merged
merged 1 commit into from
May 12, 2024
Merged

Can node_index and child_index be replaced with css selector syntax? #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions scraper/scraper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ type RegexConfig struct {
type ElementLocation struct {
Selector string `yaml:"selector,omitempty"`
JsonSelector string `yaml:"json_selector,omitempty"`
NodeIndex int `yaml:"node_index,omitempty"`
ChildIndex int `yaml:"child_index,omitempty"`
RegexExtract RegexConfig `yaml:"regex_extract,omitempty"`
Attr string `yaml:"attr,omitempty"`
Expand Down Expand Up @@ -858,7 +857,7 @@ func getTextString(e *ElementLocation, s *goquery.Selection) (string, error) {
} else {
fieldSelection = s.Find(e.Selector)
}
if len(fieldSelection.Nodes) > e.NodeIndex {
if len(fieldSelection.Nodes) > 0 {
if e.Attr == "" {
if e.EntireSubtree {
// copied from https://github.com/PuerkitoBio/goquery/blob/v1.8.0/property.go#L62
Expand All @@ -882,7 +881,7 @@ func getTextString(e *ElementLocation, s *goquery.Selection) (string, error) {
buf.Reset()
}
} else {
f(fieldSelection.Get(e.NodeIndex))
f(fieldSelection.Get(0))
fieldStrings = append(fieldStrings, buf.String())
}
} else {
Expand All @@ -896,7 +895,7 @@ func getTextString(e *ElementLocation, s *goquery.Selection) (string, error) {
}
}
} else {
fieldNode := fieldSelection.Get(e.NodeIndex).FirstChild
fieldNode := fieldSelection.Get(0).FirstChild
if fieldNode != nil {
fieldNodes = append(fieldNodes, fieldNode)
}
Expand Down