Fix #36 - Refactor model mixins into module #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #46 +/- ##
==========================================
Coverage 100% 100%
==========================================
Files 7 9 +2
Lines 170 173 +3
Branches 11 11
==========================================
+ Hits 170 173 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change pulls all of the mix-in classes used to build the User model and places them in a separate module within the package. Instead of accessing them in improved_user.models, they are now accessed in improved_user.mixins. Similarly, the UserManager is moved to improved_user.managers. All other changes are made to reflect this refactor.
To properly test the refactor, a second example project is created. This project uses the mixins to create a custom User model without putting improved_user in INSTALLED_APPS. We provide basic tests to check that the new User model is created, that migrations apply, and that the UserManager works.
The original example project is updated along the way, based on code from the new example project, which is generated using Django 2.0a1.
Finally, documentation is changed to reflect these changes, and a tutorial is provided to rapidly explain how the new example project can be mimicked.