Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulp-sass #340

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Conversation

mitchhentges
Copy link
Member

The super-out-of-date gulp-sass that we were using doesn't work on Linux with NodeJS 8.

Soon we're going to need to change from gulp-sass (now unmaintained) to node-sass with a wrapper (does gulp's vinyl cover that?)

@nerdbeere
Copy link
Member

We probably could get rid of gulp altogether :)

@nerdbeere nerdbeere merged commit 40f4145 into james-proxy:master Dec 6, 2017
@mitchhentges mitchhentges deleted the update-node-sass branch December 6, 2017 08:53
@mitchhentges
Copy link
Member Author

Dang, a lot of hate on the gulp trian 😆 Tomi and I were recently talking about using Gulp vs webpack - there's an awesome ecosystem for building electron apps with Webpack now, so there'd be a large reduction in configuration - but, our current gulp config is still faster than what's been pulled off with webpack so far 😄

Might be time to modernize so we get those juicy new webpack transform features

@nerdbeere
Copy link
Member

Don't get me wrong, I hate webpack even more than gulp. 😆
I'm a fan of simple tooling… still using browserify a lot although it's lacking a lot of features.

Maybe an interesting alternative to webpack: https://parceljs.org/
Another lightweight alternative: https://rollupjs.org/

I think it's worth investing some time in simple and robust tooling.

@tomitm
Copy link
Contributor

tomitm commented Dec 6, 2017

@nerdbeere Take a look at the electron-webpack branch. I think you might enjoy how simple it is. Also, I think this setup is as fast or faster than our current gulp setup now, keeping in mind it's also doing more (such as async component split/loading).

Rollup is designed for libraries, so it's not entirely suited for our use case as an application. I saw Parcel come out yesterday, so I'd still wait on that to mature a bit. webpack also just dropped an v4 alpha which is claiming even smaller bundle sizes because of their work on tree shaking, so the benefit of hopping on the webpack 🚆 is bundle sizes trend downwards each release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants