Additional value struct tests (#199)

* Additional value struct tests

* More

* More tests

src/Benchmarks/ExperimentalBenchmark/Program.cs

@@ -33,7 +33,9 @@ public class Benchmark
         private readonly byte[] data = new byte[10 * 1024 * 1024];
 
         private ArrayInputBuffer inputBuffer;
-        //private UnsafeSpanWriter2 spanWriter;
+        private ValueTable valueTable;
+        private ValueTable_Unsafe unsafeValueTable;
+        private Table table;
 
         [GlobalSetup]
         public void Setup()
@@ -55,6 +57,10 @@ public void Setup()
 
             ValueTable.Serializer.Write(data, t);
             inputBuffer = new ArrayInputBuffer(data);
+
+            valueTable = new ValueTable(ValueTable.Serializer.Parse(data));
+            unsafeValueTable = new ValueTable_Unsafe(ValueTable_Unsafe.Serializer.Parse(data));
+            table = new Table(Table.Serializer.Parse(data));
         }
 
         [Benchmark]
@@ -83,6 +89,12 @@ public int ParseAndTraverse_Value()
             return sum;
         }
 
+        [Benchmark]
+        public int Serialize_Value()
+        {
+            return ValueTable.Serializer.Write(this.data, this.valueTable);
+        }
+
         [Benchmark]
         public int ParseAndTraverse_Value_Unsafe()
         {
@@ -109,6 +121,12 @@ public int ParseAndTraverse_Value_Unsafe()
             return sum;
         }
 
+        [Benchmark]
+        public int Serialize_Value_Unsafe()
+        {
+            return ValueTable_Unsafe.Serializer.Write(this.data, this.unsafeValueTable);
+        }
+
         [Benchmark]
         public int ParseAndTraverse_Ref()
         {
@@ -134,6 +152,12 @@ public int ParseAndTraverse_Ref()
 
             return sum;
         }
+
+        [Benchmark]
+        public int Serialize_Ref()
+        {
+            return Table.Serializer.Write(this.data, this.table);
+        }
     }
 
     public class Program

src/FlatSharp/TypeModel/ValueStructTypeModel.cs

@@ -261,9 +261,7 @@ public override void Initialize()
                 throw new InvalidFlatBufferDefinitionException($"Can't create type model from type {this.ClrType.GetCompilableTypeName()} because it is not public.");
             }
 
-            this.CanMarshalWhenLittleEndian =
-                UnsafeSizeOf(this.ClrType) == this.inlineSize &&
-                Marshal.SizeOf(this.ClrType) == this.inlineSize;
+            this.CanMarshalWhenLittleEndian = UnsafeSizeOf(this.ClrType) == this.inlineSize;
         }
 
         private static int UnsafeSizeOf(Type t)

src/Tests/FlatSharpEndToEndTests/ValueStructs/ValueStructTests.cs

@@ -29,7 +29,7 @@ public class ValueStructTestCases
         [Fact]
         public void Basics()
         {
-            Assert.Equal(148, Marshal.SizeOf<ValueStruct>());
+            Assert.Equal(148, Unsafe.SizeOf<ValueStruct>());
         }
 
         [Fact]
@@ -334,8 +334,8 @@ private static void AssertStructsEqual(ValueStruct a , ValueStruct b)
                 Assert.Equal(a.D(i), b.D(i));
             }
 
-            Span<byte> scratchA = stackalloc byte[Marshal.SizeOf<ValueStruct>()];
-            Span<byte> scratchB = stackalloc byte[Marshal.SizeOf<ValueStruct>()];
+            Span<byte> scratchA = stackalloc byte[Unsafe.SizeOf<ValueStruct>()];
+            Span<byte> scratchB = stackalloc byte[Unsafe.SizeOf<ValueStruct>()];
 
             MemoryMarshal.Cast<byte, ValueStruct>(scratchA)[0] = a;
             MemoryMarshal.Cast<byte, ValueStruct>(scratchB)[0] = b;

src/Tests/FlatSharpTests/OracleTests/AlignmentTests.cs

@@ -193,7 +193,7 @@ public class StructVectors
             public FiveByteStruct AlignmentVec_0 { get; set; }
 
             [FlatBufferItem(1)]
-            public FiveByteStruct AlignmentVec_1 { get; set; }
+            public ValueFiveByteStruct AlignmentVec_1 { get; set; }
 
             [FlatBufferItem(2)]
             public FiveByteStruct AlignmentVec_2 { get; set; }