Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exceptions and string concat #420

Merged
merged 11 commits into from
Feb 16, 2024
Merged

Conversation

jamescourtney
Copy link
Owner

No description provided.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6260caf) 97.31% compared to head (b78e882) 97.01%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   97.31%   97.01%   -0.31%     
==========================================
  Files         126      126              
  Lines        9698     9735      +37     
  Branches      786      787       +1     
==========================================
+ Hits         9438     9444       +6     
- Misses        169      200      +31     
  Partials       91       91              
Files Coverage Δ
...harp.Compiler/SchemaModel/RpcServiceSchemaModel.cs 98.98% <100.00%> (ø)
...iler/SchemaModel/StructVectorPropertyFieldModel.cs 96.40% <100.00%> (ø)
...arp.Compiler/SchemaModel/ValueStructSchemaModel.cs 94.48% <100.00%> (+0.03%) ⬆️
...harp.Compiler/SchemaModel/ValueUnionSchemaModel.cs 96.95% <100.00%> (ø)
src/FlatSharp.Runtime/FlatSharpInternal.cs 87.50% <100.00%> (+12.50%) ⬆️
src/FlatSharp.Runtime/IO/InputBufferExtensions.cs 96.07% <100.00%> (-0.22%) ⬇️
src/FlatSharp.Runtime/IO/SpanWriterExtensions.cs 95.55% <ø> (ø)
src/FlatSharp.Runtime/SerializationHelpers.cs 93.10% <100.00%> (-0.84%) ⬇️
src/FlatSharp.Runtime/SerializerSettings.cs 97.29% <100.00%> (-2.71%) ⬇️
src/FlatSharp.Runtime/SortedVectorHelpers.cs 98.80% <100.00%> (-0.60%) ⬇️
... and 24 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6260caf...b78e882. Read the comment docs.

@jamescourtney jamescourtney merged commit a1fad43 into main Feb 16, 2024
6 of 8 checks passed
@jamescourtney jamescourtney deleted the exception_refactor branch February 16, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant