-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed union generator when processing union with custom enum value #447
fix: fixed union generator when processing union with custom enum value #447
Conversation
bab5a5b
to
2377038
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I'd like to clear up a few details of what impact the assigned numbers here have on the binary format.
Not related to your PR, but can you share some details about the nature of your real world project? I'm always curious how people are using FlatSharp. |
FlatSharp looks more elegant than the official C# implementation.💕 We have a game engine developed in C++ and using Flatbuffer as the serialization format. We use the official flatbuffer implementation on the C++ side and during this process, we found some bugs in the official flatbuffer implementation and submitted some PRs to them. |
Thanks! I'm planning to review this PR in depth tonight. I need to check out your branch to actually get a feel for the changes. Sorry for the delay. |
In our real-world project, some unions define custom enum values, in which case FlatSharp will report compilation errors.
This PR fixes this issue.