Adjust Fraction class addition overload overflow tests

jamescowens · Mar 4, 2024 · fa83bf1 · fa83bf1
1 parent 6c4598a
commit fa83bf1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/test/util_tests.cpp b/src/test/util_tests.cpp
@@ -1648,8 +1648,8 @@ BOOST_AUTO_TEST_CASE(util_Fraction_addition_overflow_2)
 
 BOOST_AUTO_TEST_CASE(util_Fraction_addition_overflow_3)
 {
- Fraction lhs(-(std::numeric_limits<int64_t>::max() / 2 + 1), 1);
- Fraction rhs(-(std::numeric_limits<int64_t>::max() / 2 + 1), 1);
+ Fraction lhs(std::numeric_limits<int64_t>::min() / 2 + 1, 1);
+ Fraction rhs(std::numeric_limits<int64_t>::min() / 2, 1);
 
  std::string err;
 
@@ -1664,8 +1664,8 @@ BOOST_AUTO_TEST_CASE(util_Fraction_addition_overflow_3)
 
 BOOST_AUTO_TEST_CASE(util_Fraction_addition_overflow_4)
 {
- Fraction lhs(-(std::numeric_limits<int64_t>::max() / 2 + 1), 1);
- Fraction rhs(-(std::numeric_limits<int64_t>::max() / 2 + 2), 1);
+ Fraction lhs(std::numeric_limits<int64_t>::min() / 2, 1);
+ Fraction rhs(std::numeric_limits<int64_t>::min() / 2, 1);
 
  std::string err;
 

diff --git a/src/util.h b/src/util.h
@@ -684,7 +684,7 @@ class Fraction {
 
  if (a < 0 && b < 0) {
  // Remember b is negative here, so the difference below is GREATER than std::numeric_limits<int64_t>::min().
- if (a >= std::numeric_limits<int64_t>::min() - b) {
+ if (a >= std::numeric_limits<int64_t>::min() + 1 - b) {
  return a + b;
  } else {
  throw std::overflow_error("fraction addition of a + b where a < 0 and b < 0 results in an overflow");