Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Addresses #4. http(s) and sqs should support subscriptions with the
RawMessageDelivery
attribute set to"true"
, allowing the message paylod to be delivered without the SNS metadata wrapping it. This also fixes Slack to always send the raw message as it doesn't support the SNS Message format.Changes
Testing and Validation Steps
HTTP(S)
RawMessageDelivery
attribute.RawMessageDelivery
attribute viaSetSubscriptionAttribute
.MessageStructure
attribute (set tojson
) with an entry in the payload forhttp
.SQS
1.Create a new SQS queue.
2. Create a subscription with the sqs endpoint and the
RawMessageDelivery
attribute.3. Publish a message to the subscription topic.
4. Validate that the message is received by the endpoint with the SNS metadata included.
5. Add the
RawMessageDelivery
attribute viaSetSubscriptionAttribute
.6. Publish a message to the topic.
7. Validate that the raw message payload is delivered without the SNS metadata.
8. Publish a message using the
MessageStructure
attribute (set tojson
) with an entry in the payload forsqs
.9. Validate that the raw message payload is delivered without the SNS metadata.
Slack
RawMessageDelivery
attribute.