Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The endpoint for each subscription was not rendering correctly in the responses because we were URL encoding the value. This caused endpoints to render in the URL encoded format instead of the expected unencoded format. Because the response is an XML response we need to encode
&
characters as&
instead of URL encoding the entire endpoint.Changes
xmlEncodedEndpointUrl()
method to theSubscription
data class.ListSubscriptions
,ListSubscriptionsByTopic
,GetSubscriptionAttributes
) to use the XML-encoded endpoint url.Testing and Validation Steps
&
character.aws sns list-subscriptions --endpoint-url http://localhost:9911
.&
.aws sns get-subscription-attributes --endpoint-url http://localhost:9911 --subscription-arn <subscription-arn>
.&
.aws sns list-subscritptions-by-topic --endpoint-url http://localhost:9911 --topic-arn <subscription topic arn>
.&
.