Type check for better fortran interface support #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskermode
approved these changes
Jan 12, 2023
f90wrap/pywrapgen.py
Outdated
| @@ -155,7 +155,8 @@ def _format_line_no(lineno): | |||
| class PythonWrapperGenerator(ft.FortranVisitor, cg.CodeGenerator): | |||
| def __init__(self, prefix, mod_name, types, f90_mod_name=None, | |||
| make_package=False, kind_map=None, init_file=None, | |||
| py_mod_names=None, class_names=None, max_length=None): | |||
| py_mod_names=None, class_names=None, max_length=None, | |||
| type_check=None): | |||
There was a problem hiding this comment.
default value of type_check should probably be False, not None?
|
OK, I understand the point about polymorphism now. Happy to merge once you fix the minor issue with the |
|
I fixed the type_check default value. I also reworked a bit the case where the fortran type is not known to f90wrap. |
jameskermode
approved these changes
Jan 18, 2023
|
thank you! I'll wait for the upcoming build improvements before doing a new release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two current limitations:
This pr adds type and shape checks in the python wrapper function. It raises TypeError if the type/shape provided to the python function does not match the type/shape of the wrapped Fortran subroutine.
It allows better support for Fortran interfaces. For instance, it enables one to wrap:
Known limitation: as Fortran
logicalis mapped to Cintthere is no differentiation of pythonboolandint32.It should solve issue #107
A command line flag is added to activate those checks, so that old behavior is still possible and is the default.
The flag could be removed so that the checks are always added, but this could break existing code. It does break some tests in the exemple directory, though they seem easily fixable.