Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop legacy code: html_escape_once conditional, how "newer"? #164

Closed
tagliala opened this issue Sep 3, 2024 · 1 comment · Fixed by #163
Closed

Drop legacy code: html_escape_once conditional, how "newer"? #164

tagliala opened this issue Sep 3, 2024 · 1 comment · Fixed by #163

Comments

@tagliala
Copy link
Contributor

tagliala commented Sep 3, 2024 •
edited
Loading

inline_svg/lib/inline_svg/action_view/helpers.rb

Line 26 in 275d2af

# html_escape_once was introduced in newer versions of Rails.

https://github.com/jamesmartin/inline_svg/blame/2d5c4d1be8601ec078d86db1f665cd3dcb9428fb/lib/inline_svg/action_view/helpers.rb#L26

ed19d7c

Ref: #161
@tagliala
Copy link
Contributor Author

tagliala commented Sep 3, 2024 •
edited
Loading

It is present in 6.1.0, the minimum required Rails version

https://github.com/rails/rails/blob/v6.1.0/activesupport/lib/active_support/core_ext/string/output_safety.rb#L50

In 7.1.0, this file has been moved to their own file rails/rails@9f5dee3

tagliala added a commit to tagliala/inline_svg that referenced this issue Sep 3, 2024
@tagliala
Remove legacy conditional check
13bba98 
`ERB::Util.html_escape_once` is available in all supported Rails
versions

Close jamesmartin#164
tagliala added a commit to tagliala/inline_svg that referenced this issue Sep 3, 2024
@tagliala
Remove legacy conditional check
b1bf1b9 
`ERB::Util.html_escape_once` is available in all supported Rails
versions

Close jamesmartin#164
tagliala added a commit to tagliala/inline_svg that referenced this issue Sep 3, 2024
@tagliala
Remove legacy conditional check
28668e6 
`ERB::Util.html_escape_once` is available in all supported Rails
versions

Close jamesmartin#164
tagliala added a commit to tagliala/inline_svg that referenced this issue Sep 4, 2024
@tagliala
Remove legacy conditional check
3dc5cc0 
`ERB::Util.html_escape_once` is available in all supported Rails
versions

Close jamesmartin#164
tagliala added a commit to tagliala/inline_svg that referenced this issue Sep 4, 2024
@tagliala
Remove legacy conditional check
3238b39 
`ERB::Util.html_escape_once` is available in all supported Rails
versions

Close jamesmartin#164
tagliala added a commit to tagliala/inline_svg that referenced this issue Sep 4, 2024
@tagliala
Drop legacy Ruby and Rails support
cb9f2b6 
`ERB::Util.html_escape_once` is available in all supported Rails
versions

Also:
- Opt-in for MFA (security)
- Move development gems to Gemfile

Close jamesmartin#161, close jamesmartin#164
@tagliala tagliala mentioned this issue Sep 4, 2024
Merged
@tagliala tagliala changed the title Drop legacy code: html_escape_once conditional, how older? Drop legacy code: html_escape_once conditional, how "newer"? Sep 4, 2024
tagliala added a commit to tagliala/inline_svg that referenced this issue Sep 5, 2024
@tagliala
Drop legacy Ruby and Rails support
bf39922 
`ERB::Util.html_escape_once` is available in all supported Rails
versions

Also:
- Opt-in for MFA (security)
- Move development gems to Gemfile

Close jamesmartin#161, close jamesmartin#164
@tagliala tagliala mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop legacy Ruby, Rails, and Webpacker support tagliala/inline_svg
1 participant
@tagliala