Modify WebpackAssetFinder to serve file from dev server if one is running (with fixes) #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning. Apply PR jamesmartin#101 with the suggested changes. Co-authored-by: Joe Peduto <joe.peduto@creativemoxie.com>
jamesmartin
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
@connorshea thank you for taking the time to open this PR. I appreciate it! ✨
I'm going to add an update to the changelog in this branch and then merge this to master. I believe this will be backwards compatible so I can release it as a patch update.
|
👍 FWIW I'm using this branch in my app and it works fine, I deployed on Saturday and it worked fine in production as well. |
|
@jamesmartin any update on when this will merge? |
|
Released in v1.7.0. |
|
Thank you! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of #101, this allows the gem to pick up new SVGs automatically when used with Webpacker and webpack-dev-server. This is much better than the previous situation, which required running
rake assets:precompileto get new icons to load in development.I've added @moxie as a coauthor of this commit. but If you'd rather have me rebase this branch to include the commits from #101, I can do that.