Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viewBox option #142

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Aug 25, 2022

Adds the viewBox attribute to the default transformations, as the view_box option.

I’ve been using this as a custom transformation for a while in production but since viewBox is a very common attribute on inline SVGs, I think it would be nice to have this as a default.

@sunny sunny force-pushed the add-viewbox-transformation branch from 08f4652 to d098773 Compare August 25, 2022 13:25
@sunny sunny mentioned this pull request Aug 25, 2022
2 tasks
@sunny sunny force-pushed the add-viewbox-transformation branch from dc5353d to f6eb962 Compare August 25, 2022 13:39
Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, seems like a generally applicable and useful transformation! 👍

@jamesmartin jamesmartin merged commit b9f4f72 into jamesmartin:main Jan 9, 2023
@sunny
Copy link
Contributor Author

sunny commented Jan 9, 2023

Yay! Thank you maintaining inline_svg 🎉

@sunny sunny deleted the add-viewbox-transformation branch January 9, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants