Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set asset finder from callable #154

Closed
wants to merge 5 commits into from
Closed

Set asset finder from callable #154

wants to merge 5 commits into from

Commits on Oct 24, 2023

  1. Set asset finder from callable 

    It fixes jamesmartin#151 by allowing the asset finder to be a callable object. This is
useful when the asset pipeline is not ready when the initializer is run, for
example, when using Propshaft.

I don't know if this is the best way to solve this problem. On the one hand,
Propshaft could be done when its initializer is run, but on the other hand,
this gem's railtie assumes the asset pipeline is ready.
    @xymbol
    xymbol committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ab2b082 View commit details
    Browse the repository at this point in the history

  2. Update lib/inline_svg.rb 

    Co-authored-by: James Martin <jamesmartin@users.noreply.github.com>
    @xymbol @jamesmartin
    xymbol and jamesmartin authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    76a9504 View commit details
    Browse the repository at this point in the history

  3. Call method instead

    @xymbol
    xymbol committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c84c9d6 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into callable

    @xymbol
    xymbol committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6103c1b View commit details
    Browse the repository at this point in the history

  5. Add spec example

    @xymbol
    xymbol committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    cb2b387 View commit details
    Browse the repository at this point in the history