Change asset finder configuration #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the way the asset finder is configured. Instead of setting the asset finder from an initializer to a specific class, the asset finder is now detected unless configured otherwise. This allows InlineSvg to work with Sprockets, Propshaft, or a fallback static asset finder without any configuration.
It allows caching at the finder without class instance variables.
xymbol
commented
Oct 26, 2023
lib/inline_svg.rb
Outdated
| end | ||
|
|
||
| def asset_finder | ||
| @asset_finder ||= matching_asset_finder |
There was a problem hiding this comment.
Here, we could raise if no asset finder is set or detected.
There was a problem hiding this comment.
The goal is to have these classes behave like lazy, auto-detect adapters. Also, to draw a line between the asset finder and the asset result.
There was a problem hiding this comment.
We could name this "Rails static asset finder" as it depends on a Rails configuration, i.e. it cannot work stand-alone or with a non-Rails environment.
That's for another refactor, but we can drop it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way the asset finder is configured. Instead of setting the asset finder from an initializer to a specific class, the asset finder is now detected unless configured otherwise.
This allows InlineSvg to work with Sprockets, Propshaft, or a fallback static asset finder without any configuration.