RuboCop Stage III: Fix safe performance offenses #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tagliala
commented
Sep 16, 2024
•
tagliala
commented
- Performance/CompareWithBlock
- Performance/ConstantRegexp
- Performance/RedundantSplitRegexpArgument
- Performance/StringReplacement
tagliala
force-pushed
the
chore/rubocop-safe-performance-offences
branch
from
4aa5793
to
7cb6fa6
Compare
- Performance/CompareWithBlock - Performance/ConstantRegexp - Performance/RedundantSplitRegexpArgument - Performance/StringReplacement
tagliala
force-pushed
the
chore/rubocop-safe-performance-offences
branch
from
7cb6fa6
to
4c85530
Compare
|
@jamesmartin rebased and ready for review |
jamesmartin
approved these changes
Oct 9, 2024
|
Thanks, @tagliala! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.