Handle non-ASCII characters in titles #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for a great gem!
I tried using an ö in the title of an inlined svg and noticed it got stripped from the output.
I think this is happening because
to_html
outputs HTML entity codes for these characters by default but when these are then parsed withNokogiri::XML::Document.parse
they get stripped out since they aren't supported in XML:Explicitly setting the encoding to "UTF-8" when calling
to_html
disables generating the entities:Setting the encoding to "UTF-8" when parsing the document makes sure it's implicitly set to "UTF-8" wherever
to_html
is called later.