Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style attribute #71

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Sep 26, 2017

This pull request allows using a style attribute on SVGs, instead of having to add custom transformations to your app.

E.g.:

inline_svg(…, style: "margin-left: 15px")

=>

<svg style="margin-left: 15px">…</svg>

Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunny thanks for opening this PR, I really appreciate it! 👍

I'll merge and release a new version including this change in the next week or so.

@jamesmartin jamesmartin merged commit 25fa64e into jamesmartin:master Sep 26, 2017
@sunny
Copy link
Contributor Author

sunny commented Sep 27, 2017

Yay! Thanks for the swift merge and maintaining inline_svg \o/

@sunny sunny deleted the add-style-transformation branch September 27, 2017 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants