Add aria_hidden option
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes [jamesmartin#72]. Sometimes SVGs are simply decorative and therefore should be removed from the accessibility tree. Here’s an example: ```erb <p> <%= inline_svg "checkmark-icon.svg" %> Success! </p> ``` You can imagine this as a simple flash message, letting the user know that their action succeeded. We have the word ‘Success’, preceded by a checkmark icon to visually represent the state. In such a situation, the icon is simply decorative; it’s repeating content already conveyed by the word ‘Success.’ If we apply `aria-hidden="true"` to the SVG, we can remove it from the accessibility tree and avoid the repetition. [jamesmartin#72]: jamesmartin#72
jamesmartin
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72.
Sometimes SVGs are simply decorative and therefore should be removed
from the accessibility tree. Here’s an example:
You can imagine this as a simple flash message, letting the user know
that their action succeeded. We have the word ‘Success’, preceded by a
checkmark icon to visually represent the state.
In such a situation, the icon is simply decorative; it’s repeating
content already conveyed by the word ‘Success.’ If we apply
aria-hidden="true"to the SVG, we can remove it from the accessibilitytree and avoid the repetition.