Adds missing array to cached_asset_file.rb #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an array where one appears to be missing.
Receiving this error in Rails 4.0.3:
```
/gems/inline_svg-1.3.0/lib/inline_svg/cached_asset_file.rb:17: syntax error, unexpected ',' (SyntaxError)
def initialize(paths:, filters: [])
```
jamesmartin
approved these changes
Nov 27, 2017
There was a problem hiding this comment.
@DustinArmstrong thanks for opening this PR. I appreciate you helping to improve this project! 👍
Given the syntax error I assume you're seeing the problem while running a version of Ruby older than 2.1 (which introduced required keyword arguments). I've never set a minimum required Ruby version for this gem, although maybe I should in future.
In any case, I think your fix makes sense. Thanks again! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an array where one appears to be missing.
Causes this error in Rails 4.0.3: