This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Refactor ELCAssetTablePicker to be a UICollectionViewController #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a moment to fill out the following:
Cleans up #650
Changes Proposed in this pull request:
ELCAssetTablePicker
, likely due to its noted age in the original PR, was acting a lot like a poor mansUICollectionViewController
. I've made it a less-poor mans implementation deriving from CollectionView and tried to clean the API up a bit. This should be easier to maintain and behave less quirky (i.e. not having to listen to rotation changes and manually recalculate layout).I didn't do this here, but I also think we should unify the single-select vs multi-select codepaths, and not use two different view controllers in the two cases. I assume this wasn't done because the multi-select was just introduced and so is untested? I actually stumbled on this refactor because I was trying to debug a multi-select issue and wasn't aware I was looking at the wrong view controller : )
Also, a disclaimer that I am very new to Xamarin/C#, so please excuse any idiom violations.