This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Fix for LG phone crashes when using camera #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LG phones and works okay without it.
Fix for LG phones
Added comments; forgot to comment out PutExtra line
…lly needs to be set before setting.
Added check for IntentExtra before setting on Android
Eltee-Taiwo
reviewed
Jul 8, 2019
| @@ -27,7 +27,10 @@ public static void UseBackCamera(this Intent intent) | |||
|
|
|||
| // Android API 25 and up | |||
| intent.PutExtra(extraBackPost25, 1); | |||
| intent.PutExtra(extraUserFront, false); | |||
|
|
|||
| var val = intent.GetBooleanExtra(extraUserFront, false); | |||
There was a problem hiding this comment.
Any idea when the Nuget package is going to be updated with this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some LG phones (LG v30 for sure) crash when setting the android.intent.extra.USE_FRONT_CAMERA extra to false when it is already false.
Please take a moment to fill out the following:
Fixes # .
Changes Proposed in this pull request: