-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide how to deal with heapless-v0.8 #121
Comments
tagging the postcard-2.0 label so in the future I remember to remove whatever deprecated notice I add for fixing this in 1.0. |
Hi James,
update: found the master branch resolves, this thanks https://github.com/jamesmunns/postcard/blob/main/Cargo.toml#L32 Cheers |
Hi, In my view the best approach would be to get rid of other crates in the public API, as you proposed in #128 . However, I assume that releasing 2.0 might take a while, so as a temporary solution doing what you proposed here (having the 2 features flags) sounds reasonable. In one of my projects I've used heapless 0.8 for quite a while before deciding on using postcard, which means that I either need to do a breaking downgrade now or implement my own heapless (0.8) compatibility for postcard. I guess I could also depend on postcard master, but I'm not really keen on doing so. |
heapless types appear in the public interface, so upgrading it would be a breaking change.
I am not certain, but I've considered doing the following:
heapless-v0_7
andheapless-v0_8
features, using those versions specifically, maybe in some module-d scope, for things liketo_vec
,to_vec_cobs
heapless
as an alias forheapless-v0_7
, but marking it as deprecated.Open to feedback if people think there is a preferrable solution.
Originally posted by @jamesmunns in #115 (comment)
The text was updated successfully, but these errors were encountered: