Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heapless #115

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Update heapless #115

merged 2 commits into from
Jan 14, 2024

Conversation

luqasz
Copy link
Contributor

@luqasz luqasz commented Nov 14, 2023

No description provided.

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for cute-starship-2d9c9b canceled.

Name Link
🔨 Latest commit a5bf5e2
🔍 Latest deploy log https://app.netlify.com/sites/cute-starship-2d9c9b/deploys/65a33ba48cd6ba0009168e13

@dzamlo
Copy link

dzamlo commented Nov 26, 2023

This would be a breaking changes.

@jamesmunns
Copy link
Owner

Yeah, I agree with @dzamlo, heapless types appear in the public interface, so upgrading it would be a breaking change.

I am not certain, but I've considered doing the following:

  • adding heapless-v0_7 and heapless-v0_8 features, using those versions specifically, maybe in some module-d scope, for things like to_vec, to_vec_cobs
  • keeping heapless as an alias for heapless-v0_7, but marking it as deprecated.

Open to feedback if people think there is a preferrable solution.

@jamesmunns jamesmunns merged commit 393e18a into jamesmunns:main Jan 14, 2024
4 checks passed
@jamesmunns
Copy link
Owner

Merging and will sort out the versioning stuff before the next release.

@luqasz luqasz deleted the heapless branch January 14, 2024 02:23
stabl-gjn pushed a commit to Stabl-Energy/postcard that referenced this pull request May 7, 2024
Co-authored-by: James Munns <james@onevariable.com>
stabl-gjn pushed a commit to Stabl-Energy/postcard that referenced this pull request May 7, 2024
Co-authored-by: James Munns <james@onevariable.com>
Manishearth added a commit to Manishearth/postcard that referenced this pull request Aug 19, 2024
jamesmunns pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants